feat: improve IP blacklist import feedback#1183
Merged
GyulyVGC merged 5 commits intoMay 9, 2026
Merged
Conversation
Owner
|
Hey @TheMasterOfDisasters I like the idea but I prefer to keep things simple and show only a success message with the number of IPs and CIDRs. So can you please remove the translations and all the statuses? I'd like something just like this (not showing one of the two if it's zero):
|
Contributor
Author
|
Thanks @GeorgeLS for the feedback. I’ll move this back to draft while I simplify it and keep only the IP/CIDR counts as requested. |
Contributor
Author
|
Hey @GyulyVGC, updated as requested. I removed the translations and extra statuses, and kept only the IP/CIDR counts. |
Owner
|
Awesome, thanks for the quick update |
GyulyVGC
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Summary
This PR improves feedback for imported IP blacklist files.
Previously, when an imported blacklist file could not be used, the settings page only showed the path in the danger/error style. It was not clear whether the file could not be read, was empty, or did not contain any valid blacklist entries.
With this change, the settings page now displays a short status message for the IP blacklist import.
What changed
IpBlacklistLoadStatusenum to represent blacklist loading/import state.Motivation
After adding CIDR support, the blacklist import became more useful with public blacklist sources, but failed imports were still difficult to understand from the UI.
For example, if a file was invalid or unreadable, users only saw an error-colored path without a clear explanation. This PR makes the blacklist import state visible so users can understand what happened and how to fix it.
Testing
Tested locally with:
Screenshots
No blacklist selected:



Invalid blacklist file:
Valid blacklist loaded: