-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow displaying age/page IDs in Object Browser tree #84
base: master
Are you sure you want to change the base?
Conversation
This no longer works for pages now that they might have IDs displayed. For ages it's technically still fine, but better to fix those as well to avoid unpleasant surprises later.
e4ee6b9
to
a7d27b4
Compare
src/PrpShop/QPlasmaTreeItem.cpp
Outdated
break; | ||
|
||
case kTypeAge: | ||
setText(0, fAge); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we want to show the sequence prefix next to Age folder names too? It's probably rare that people are opening multiple Ages in PlasmaShop, but the wording of "Show Age/Page IDs" makes me expect it would also be displayed at the Age level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would make sense. I think I was too lazy to implement that part because the age items currently only store the name and not the sequence prefix... But it shouldn't be hard to add the extra field for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supersedes #78. Adds an option to display age/page IDs next to page names, similar to the existing option to display type IDs next to class names.