Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Tiam Crystal page #148

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Adds Tiam Crystal page #148

wants to merge 3 commits into from

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented May 18, 2022

Adds the objects and assets for the Tiam Crystal page.

Page will be found inside the Tiam Age.
Will be another PR for that.

@Hazado Hazado mentioned this pull request May 18, 2022
Draft
@Hoikas Hoikas added enhancement New feature or request subjective An issue or fix that is artistic or creative in nature labels May 27, 2022
@ZarothYe
Copy link
Contributor

ZarothYe commented Jun 3, 2022

I think I saw some screenshots for this page (and the other pages) in discord at one point. Can we add some here to give some idea of what the page graphic and results in Relto will be for the people who may not be following the discord? And for posterity since discord history is hard to trawl through? :)

@Hazado
Copy link
Contributor Author

Hazado commented Aug 3, 2022

image
image

Deledrius
Deledrius requested changes Aug 3, 2022
View reviewed changes
Copy link
Member

@Deledrius Deledrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting idea for an addition. It reminds me of the crystal trees in Ahnonay.

The texturing on these seems off though, as it doesn't match the lighting in the locations of Relto they are growing from. It looks like a full-bright object sitting on Relto, but without any glow that would justify that appearance. The UV mapping also looks a bit haphazard in places, and the texture itself is very simple and repetitive. Compare it to the crystal trees on Ahnonay, and you can see there a variation in texture and lighting that makes them actually fit in at the place they've been planted.

I would suggest this needs some blended textures and more thought to the UV mapping before it's considered ready.

Right now this is a good first pass at a cool new Relto page.

@Hazado
Copy link
Contributor Author

Hazado commented Aug 3, 2022

They are meant to match the Crystals from Tiam age. UV Mapping is the same as used in Tiam.
They do have a glow in-game.

@Deledrius
Copy link
Member

Deledrius commented Aug 3, 2022 •
edited
Loading

They are meant to match the Crystals from Tiam age. UV Mapping is the same as used in Tiam. They do have a glow in-game.

Ah, so Tiam should be blocking on a fix for this problem as well. They look unfinished and don't match the visual fidelity expected here in Relto, and either don't match Tiam either or Tiam itself needs additional work as a whole.

@Deledrius
Copy link
Member

I think I saw some screenshots for this page (and the other pages) in discord at one point. Can we add some here to give some idea of what the page graphic and results in Relto will be for the people who may not be following the discord? And for posterity since discord history is hard to trawl through? :)

Indeed, I believe this review is the first I'm seeing of these additions.

@Hazado
First push for Page 29
ce67c0a 
Personal_District_psnlFanYeeshaPages01.prp
[Scene Node - Personal_psnlFanYeeshaPages01] Add scene objects "Page05_Kickables_VisController", Page29_TiamCrystal_CollJadetree1", "Page29_TiamCrystal_CollJadetree2", "Page29_TiamCrystal_CylGreen1", "Page29_TiamCrystal_CylGreen2", "Page29_TiamCrystal_CylGreen3", "Page29_TiamCrystal_CylGreen4", "Page29_TiamCrystal_CylGreen5", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3", "Page29_TiamCrystal_Jadepiece1", "Page29_TiamCrystal_Jadepiece2", "Page29_TiamCrystal_Jadepiece3", "Page29_TiamCrystal_Jadetree1", "Page29_TiamCrystal_Jadetree2", "Page29_TiamCrystal_Jadetree3", "Page29_TiamCrystal_Jadetree4", "Page29_TiamCrystal_Jadetree5", "Page29_TiamCrystal_Jadetree6", "Page29_TiamCrystal_Jadetree7", "Page29_TiamCrystal_RgnPlingsound1", "Page29_TiamCrystal_RgnPlingsound2", "Page29_TiamCrystal_SoundKick1", "Page29_TiamCrystal_SoundKick2", "Page29_TiamCrystal_SoundKick3", "Page29_TiamCrystal_SoundPling1" and "Page29_TiamCrystal_SoundPling2"
[Scene objects - NEW] "Page05_Kickables_VisController", Page29_TiamCrystal_CollJadetree1", "Page29_TiamCrystal_CollJadetree2", "Page29_TiamCrystal_CylGreen1", "Page29_TiamCrystal_CylGreen2", "Page29_TiamCrystal_CylGreen3", "Page29_TiamCrystal_CylGreen4", "Page29_TiamCrystal_CylGreen5", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3", "Page29_TiamCrystal_Jadepiece1", "Page29_TiamCrystal_Jadepiece2", "Page29_TiamCrystal_Jadepiece3", "Page29_TiamCrystal_Jadetree1", "Page29_TiamCrystal_Jadetree2", "Page29_TiamCrystal_Jadetree3", "Page29_TiamCrystal_Jadetree4", "Page29_TiamCrystal_Jadetree5", "Page29_TiamCrystal_Jadetree6", "Page29_TiamCrystal_Jadetree7", "Page29_TiamCrystal_RgnPlingsound1", "Page29_TiamCrystal_RgnPlingsound2", "Page29_TiamCrystal_SoundKick1", "Page29_TiamCrystal_SoundKick2", "Page29_TiamCrystal_SoundKick3", "Page29_TiamCrystal_SoundPling1" and "Page29_TiamCrystal_SoundPling2"
[Layer - Page29_TiamCrystal_lightgreen] New
[Material - Page29_TiamCrystal_lightgreen] New
[Audio Interface - Page29_TiamCrystal_SoundPling1] New
[Audio Interface - Page29_TiamCrystal_SoundPling2] New
[Audio Interface - Page29_TiamCrystal_SoundKick1] New
[Audio Interface - Page29_TiamCrystal_SoundKick2] New
[Audio Interface - Page29_TiamCrystal_SoundKick3] New
[Win Audible - Page29_TiamCrystal_SoundPling1] New
[Win Audible - Page29_TiamCrystal_SoundPling2] New
[Win Audible - Page29_TiamCrystal_SoundKick1] New
[Win Audible - Page29_TiamCrystal_SoundKick2] New
[Win Audible - Page29_TiamCrystal_SoundKick3] New
[Coord interface - NEW] "Page29_TiamCrystal_SoundPling1", "Page29_TiamCrystal_SoundPling2", "Page29_TiamCrystal_SoundKick1", "Page29_TiamCrystal_SoundKick2", "Page29_TiamCrystal_SoundKick3", "Page29_TiamCrystal_Jadepiece1", "Page29_TiamCrystal_Jadepiece2", "Page29_TiamCrystal_Jadepiece3", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3", "Page29_TiamCrystal_CollJadeTree1", "Page29_TiamCrystal_CollJadeTree2"
[Draw Interface - NEW] "Page29_TiamCrystal_Jadetree1", "Page29_TiamCrystal_Jadetree2", "Page29_TiamCrystal_Jadetree3", "Page29_TiamCrystal_Jadetree4", "Page29_TiamCrystal_Jadetree5", "Page29_TiamCrystal_Jadetree6", "Page29_TiamCrystal_Jadetree7", "Page29_TiamCrystal_Jadepiece1", "Page29_TiamCrystal_Jadepiece2", "Page29_TiamCrystal_Jadepiece3", "Page29_TiamCrystal_CylGreen1", "Page29_TiamCrystal_CylGreen2", "Page29_TiamCrystal_CylGreen3", "Page29_TiamCrystal_CylGreen4", "Page29_TiamCrystal_CylGreen5"
[Sim Interface - NEW] "Page29_TiamCrystal_RgnPlingsound1", "Page29_TiamCrystal_RgnPlingsound2", "Page29_TiamCrystal_Jadetree1", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3", "Page29_TiamCrystal_CollJadetree1", "Page29_TiamCrystal_CollJadetree"
[Sound Buffer - NEW] "Page29_TiamCrystal_Tiam_Pling.ogg:L", "Page29_TiamCrystal_Tiam_Pling.ogg:R", "Page29_TiamCrystal_Tiam_Pling1.ogg:L", "Page29_TiamCrystal_Tiam_Pling1.ogg:R", "Page29_TiamCrystal_Tiam_Pling2.ogg:L", "Page29_TiamCrystal_Tiam_Pling2.ogg:R"
[Picking Detector - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Logic Modifier - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Activator Conditional Object - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Object in Box Conditional Object - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Gen Physical - NEW] "Page29_TiamCrystal_RgnPlingsound1", "Page29_TiamCrystal_RgnPlingsound2", "Page29_TiamCrystal_Jadetree1", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3", "Page29_TiamCrystal_CollJadetree1", "Page29_TiamCrystal_CollJadetree"
[Drawable Span - Page29_TiamCrystal_00000000_0Spans] NEW
[Random Sound Mod - NEW] "Page29_TiamCrystal_SoundKick1", "Page29_TiamCrystal_SoundKick2", "Page29_TiamCrystal_SoundKick3"
[Object in Volume Detector - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Responder Modifier - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Win32 Static Sound - NEW] "Page29_TiamCrystal_Sfx-SoundPling1:L", "Page29_TiamCrystal_Sfx-SoundPling1:R", "Page29_TiamCrystal_Sfx-SoundPling2:L", "Page29_TiamCrystal_Sfx-SoundPling2:R", "Page29_TiamCrystal_Sfx-SoundKick1:L", "Page29_TiamCrystal_Sfx-SoundKick1:R", "Page29_TiamCrystal_Sfx-SoundKick2:L", "Page29_TiamCrystal_Sfx-SoundKick2:R", "Page29_TiamCrystal_Sfx-SoundKick3:L", "Page29_TiamCrystal_Sfx-SoundKick3:R"
[Python File Mod - cPythYeeshaPage07 - Vis Controller] Added 4 - Scene Object - "Page29_TiamCrystal_Jadetree2" and "Page29_TiamCrystal_CylGreen2"
[Python File Mod - cPythYeeshaPage05 - Vis Controller] NEW
[Python File Mod - cPythYeeshaPage29 - Tiam Crystal On] NEW
[Interface Info Modifier - NEW] "Page29_TiamCrystal_PlingSound1", "Page29_TiamCrystal_PlingSound2"
[Physical Sound Group - NEW] "Page29_TiamCrystal_SURFACEGEN_kMetal", "Page29_TiamCrystal_JadeCubeRndSnd1", "Page29_TiamCrystal_JadeCubeRndSnd2", "Page29_TiamCrystal_JadeCubeRndSnd3"

GUI_District_BkBookImages.prp
[Mipmap - xYeeshaPageTiamCrystal.dds] New
[Image Lib Mod - StandardBookImageLib] Added Mipmap "xYeeshaPageTiamCrystal.dds"

GUI_District_YeeshaPageGUI.prp
[Scene Node - GUI_YeeshaPageGUI] Adds Scene object "YeeshaPage29-TiamCrystal"
[Scene Object - YeeshaPage29-TiamCrystal" NEW
[Mipmap - xYeeshaPageTiamCrystal.dds] NEW
[Layer - Map #733026] NEW
[Material - sketchTiamCrystal] NEW
[Coord Interface - YeeshaPagePlane] Added Scene object "YeeshaPage29-TiamCrystal" to children
[Coord Interface - YeeshaPage29-TiamCrystal] NEW
[Draw Interface - YeeshaPage29-TiamCrystal] NEW
[Layer Animation - Map #733026_anim] NEW
[Drawable Span - GUI_YeeshaPageGUI_10000008_0BlendSpans] Added sketchTiamCrystal to span
[GUI Dialog Mod - YeeshaPageGUI] Added GUI Button Mod "GUIYeeshaPageBtn29"
[GUI Button Mod - GUIYeeshaPageBtn29] NEW

Personal_District_Textures.prp
[Mipmap - Jade*0#0.hsm] NEW
[Mipmap - nb01bluewater2*0#0.hsm] NEW
@Hazado
Update to match Moula Q2 update
fa0fd8b
@Hazado
Update for H-uru#184
0703b00 
Include shading fix for cleft book
@Hazado Hazado marked this pull request as draft December 19, 2022 17:30
@Hoikas Hoikas mentioned this pull request Apr 23, 2023
Open
@Hoikas Hoikas added the conflict This pull request modifies binary files in a way that conflicts with history or other pull requests label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deledrius Deledrius Deledrius requested changes

Assignees
No one assigned
Labels
conflict This pull request modifies binary files in a way that conflicts with history or other pull requests enhancement New feature or request subjective An issue or fix that is artistic or creative in nature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hazado @ZarothYe @Deledrius @Hoikas