Wktgw #1371
Open
Wktgw #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanBrogan
approved these changes
Nov 15, 2024
Contributor
BrendanBrogan
left a comment
BrendanBrogan
left a comment
There was a problem hiding this comment.
Everything in the WSP scripts looks good. I tried to approve the pull request, but there were 2 conflicted files, the WSP Summaries RMD and precip_coverage_summary.R . For the WSP summaries, all the conflicted areas can just be entirely deleted, but I was not sure about the precip coverage part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @BrendanBrogan -- the aforementioned changes to the critical cell map source. The WKT files for these are now located in github. Also:
suppress_errorsto opt-out of displaying the error tales in HTML, since my specific install throws an error when saving the errors as HTML but no one else does.default = FALSEso that it behaves as per normal for everyone else.