Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BrendanBrogan @COBrogan
I made some adjustments to allow a custom bbox to be passed in via the render args -- this can also form the basis for using the database for custom bbox which was planned, but I think not fully implemented. This facilitates the zoomed in views for these WSP availability inquiries.
I tagged you all because I may have broken things in my improvements, but also, because one thing that I ran into when testing this was that there was a global name search matching anything that had gg in it, in order to iterate through and create the HTML file with render errors transcript. That broke during my testing as there were remnants in memory and I had to clear my environment to actually run the markdown successfully.
Obviously searching the global namespace for possible maps is a fraught endeavor, and also a more robust way was already in place (using the list
map_objects) but then commented out -- since it was commented out, I figured there must have been a good reason why. I couldn't guess why, but noticed that the GW critical cells maps were not added to themap_objectslist, so I added them in case that was the reason. Or maybe this was just some remnant code that snuck back in due to a reversion.Anyhow, if either of you know a good reason why we needed the global search in there, I wanted to give a heads up, and not just run ahead and merge this PR.