Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@COBrogan -- I just fixed a small bug, that is, the header info for
odbc_deletewas set to exportodbc_postwhich seemed to not cause any trouble that I could discern, but I was chasing down why the WA metrics did not seem to be updating and I found something that could be related if there was indeed some real confusion as to the function in question.Here's what I observed:
WA_90_mgdin scenario 17, I openeed the slurm log. (nano slurm-404338.out)WA_export.Rproperly, and the routine seemingly executed correctly, printing out the valid WA results in the final line of the log asCalculating basinwide available flow as -1.55203619909502 + 0 / 90 = -1.552WA_90_mgdon therunid_17prop, though all others were there.lFinal na/null check for pk vid val 9022116, so I checked the database for the pid 9022116, but found nothing.Final na/null check for pk vid val 9022116only occurs in theodbc_delete()function.odbc_deleteis called, but I could not find a reason inside the context of this WA script. It is the only script that I know of that has failed to save properties correctly.