se the hydrotools version of is.empty and populate the parent_id attr… #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibute of RomFeature classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ibute of RomFeature classes
@COBrogan @BrendanBrogan -- this is actually fairly important update. The "parent_id" property of RomFeatures, i.e. for an intake, the parent_id should point to its facility, was not being populated, even though that information WAS in the dh_feature_fielded SQL view that is loaded from ODBC. Now this works, and makes tracing things a lot easier. This also exposes the local hydrotools
is.emptyfunction, though this might be superfluous?