Skip to content

Added a configurable rebootOnLongPressTimeout and fixed the warning caused by deprecated DynamicJSonDocument#264

Open
SylvainGa wants to merge 4 commits intoHASwitchPlate:mainfrom
SylvainGa:main
Open

Added a configurable rebootOnLongPressTimeout and fixed the warning caused by deprecated DynamicJSonDocument#264
SylvainGa wants to merge 4 commits intoHASwitchPlate:mainfrom
SylvainGa:main

Conversation

@SylvainGa
Copy link

Fixed the "DynamicJsonDocument' is deprecated: use JsonDocument instead" warning caused by ArduinoJson V7 being used instead of V6.

The variable rebootOnLongPressTimeout has its own configuration entry in the Admin console now. 0 disables it and 10000 is still the default.

@SylvainGa
Copy link
Author

The switch from SPIFFS to LittleFS isn't transparent to the end user, hence why I separated it. SPIFFS has been deprecated in favor of LittleFS, which is also softer on the wear of device storage. With this change applied, every setting but wifi SSID/password will need to be re-entered. Once done, if it's an exact match to what was there before, it's transparent to Home Assistant.

@aderusha
Copy link
Collaborator

Hey thanks for the PR! I'll take a look, but to set expectations: it probably won't be quickly, and I'm unlikely to publish new binaries for feature-only releases unless something breaks. My goal here is stability over all concerns, so I'll keep this in the queue in the event a future update is required.

I absolutely will not be moving to LittleFS because it's bad for HASPone users - the features that LittleFS offers over SPIFFS are not at all used by this project, and without a migration path I'd be pushing out an update which requires everyone to re-setup their devices. It creates extra work for the user with no reward.

I'm very strongly against breaking changes, I'll do if if forced to by the HASS releases (who have fewer problems with breaking everyone's currently-working stuff), but otherwise I'll avoid such things in defense of my users' sanity.

@SylvainGa
Copy link
Author

SylvainGa commented Feb 13, 2026

No problem, I understand. That's why I separated it from the other pull request.

@SylvainGa
Copy link
Author

But if you're OK with it, I can put here a link to the binary in my repo in case someone else would want that configurable reboot hold timer.

…rtups to prevent breaking changes when 2026.4 is releaaed.
@aderusha
Copy link
Collaborator

First, thanks for the fix! I'm going to have to learn enough GH to figure out how to split this PR up as I still don't want to push out the LittleFS change. I'll dive into this this coming weekend and see how we can best approach a 1.07 release.

…igger:"

Although just done in the Blueprints I'm using. Will probably need to be done in all the other blueprints.
@SylvainGa
Copy link
Author

Hi, I sent them as individual PRs so you should be able to filter just the changes you want. There is also this issue I sent a few years ago regarding errors in the hasp_Display_Dimmer_with_Icon.yaml blueprint that I see are still present to this date.

I've also pushed another change that will prevent "Repairs" to pop up regarding the Blueprints.

trigger:
  platform:

have been replaced by

triggers:
  trigger:

I've only changed the Blueprints I'm using though. I'm guessing the others will need to be modified too, With the original code, I got a bunch of Repairs to fix the trigger/platform combination.

@aderusha
Copy link
Collaborator

NICE! Thanks for this, I'll dig into this and get an update out. Appreciate the help @SylvainGa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants