Prototype pairwise seeding and optimize find-orientations#907
Draft
joelvbernier wants to merge 3 commits intomasterfrom
Draft
Prototype pairwise seeding and optimize find-orientations#907joelvbernier wants to merge 3 commits intomasterfrom
joelvbernier wants to merge 3 commits intomasterfrom
Conversation
Collaborator
|
This needs to be updated to use the simpler formulas that Don determined over the past couple of weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tightens the performance and robustness of the legacy
find-orientationsworkflow and also prototypes a new seeded indexing path based on pairwise continuous fiber intersections (work in progress).What changed
simulateOmeEtaMaps()paintGridchunk sizing for small jobspaintGrideta/omega tolerance floor to the map bin width, with warnings when the requested tolerance is below map resolutionWhy
The original seeded workflow was robust but wasteful: it rasterized many candidate orientations along each fiber, scored them all, and relied on clustering to recover the true modes afterward.
This PR moves toward a more economical seeded-forward-model approach while also improving the existing discrete-fiber path:
paintGridand downstream scoring physically consistent with the eta-omega map resolutionBenchmark notes
On the multiruby eta-omega benchmark with the legacy
discrete-fiberspath:14.314 s,71,281candidates,3grains10.264 s,38,520candidates,3grains10.188 s,38,520candidates,3grainsSo the Friedel condensation clearly wins in the legacy path, and the spawn-aware fallback prevents multiprocessing from becoming dramatically slower on macOS.
Testing
python -m unittest tests.test_indexer tests.config.test_find_orientationsFollow-up