Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3822] refactor maintenance cron #2625

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

GarrettEHill
Copy link
Contributor

@GarrettEHill GarrettEHill commented Feb 4, 2025

Description of change

Refactor maintenance system scheduling (cron) to not get lost when either the web or worker is restarted.

How to test

Very difficult to test manually, all unit test are passing

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@GarrettEHill GarrettEHill marked this pull request as ready for review February 5, 2025 17:20
@GarrettEHill GarrettEHill changed the title Ttahub 3822/refactor maintenance cron [TTAHUB-3822] refactor maintenance cron Feb 5, 2025
@@ -226,7 +226,6 @@
"<rootDir>/src/index.ts",
"<rootDir>/src/worker.ts",
"<rootDir>/src/app.js",
"<rootDir>/src/lib/cron.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Collaborator

@thewatermethod thewatermethod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes scan correctly. Might be a good idea to deploy this to dev or sandbox and let it ride for a day just as a sanity check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants