Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Use Popover API in the Menu component #2628

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

nvms
Copy link
Collaborator

@nvms nvms commented Feb 5, 2025

Description of change

See how the border of the table peeks through the Menu in the image below? Since we aren't using a real table, we're fighting indexing weirdness here. The best solution is to use the Popover API as @thewatermethod suggested.

Before:

image

After:

Screenshot 2025-02-05 at 2 45 12 PM

How to test

  • Make sure the context menu works everywhere it was working previously, which includes the widget container header overflow menus, and any tables that have rows with an overflow menu within it.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants