[TTAHUB-3787] Enhance communication log CSV export functionality #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
fbonds,
nvms,
hardwarehuman,
kryswisnaskas and
AdamAdHocTeam
Base automatically changed from
jp/TTAHUB-3764/TTAHUB-3807/regional-comm-log
to
mb/TTAHUB-3808/communication-log-frontend
February 13, 2025 15:01
…UB-3787/export-functionality
There was a problem hiding this comment.
Overall code looks good but noticed some issues.
From the new Com Log page:
- Exporting table returns more rows than shown.
- Selecting a row and exporting results in server side error.
From the RTR:
- Exporting table exports all rows not just what was shown.
- Oddly enough the selected rows works from this path.
AdamAdHocTeam
approved these changes
Feb 14, 2025
nvms
approved these changes
Feb 14, 2025
thewatermethod
merged commit 665b7b0
into
mb/TTAHUB-3808/communication-log-frontend
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Covert RTR comm log and regional comm log to use backend driven CSV export (using the table widgets existing export doesn't work because the request includes fields not shown in the tabular data)
How to test
Export a CSV from both places, confirm the data is correct and complete
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy