-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganization and cleanup of README #2657
base: main
Are you sure you want to change the base?
Conversation
These are great changes! I still see some references to the old Ad Hoc repo if we are concerned about getting them all: References to Ad Hoc repo form right at the top in this section Also, same section, under "sandbox" "An additional deployment environment called "sandbox" is available to developers for testing and development on feature branches prior to making a commit to Ad Hoc's main branch and deploying to "dev". The current .circleci/config.yml assumes deployments to this space are being made from the Ad Hoc repository." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, one thing I noticed (and maybe it was this way before) is the "Product Planning" link in the doc takes me to "create" a new page.
@thewatermethod Thanks for pointing these out, removed the other references you found. @AdamAdHocTeam Replaced with a link to https://github.com/HHS/Head-Start-TTADP/wiki/Product-Roadmapping |
LGTM, but looks like you need to merge main in here to resolve CI issues |
Description of change
Due to significant formatting cleanup and reorg, probably the best way to review is just to look at the page as it appears on this branch. Although there are significant changes in the diff, I have tried to keep the overall structure and did not remove any of the existing content.
How to test
N/A
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy