Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3912] Support multiple grant replacement and ensure all grants being replaced have the same region and recipient #2659

Merged

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Feb 14, 2025

Description of change

So when looking into the CDI grant replacement code in updateGrantRecipients job. We currently were not supporting the updating of multiple grants becoming the single CDI replacement (many to one).

This change allows us to replace multiple grants with a CDI as long as they all have the same recipient and region id.

How to test

  • Review the code.
  • Test a case or if not possible run the test.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review February 14, 2025 22:00
@AdamAdHocTeam AdamAdHocTeam requested a review from nvms February 18, 2025 14:37
@AdamAdHocTeam AdamAdHocTeam changed the title [TTAHUB-3912] Ensure all grants being replaced have the same region and recipient [TTAHUB-3912] Support multiple grant replacement and ensure all grants being replaced have the same region and recipient Feb 18, 2025
@AdamAdHocTeam AdamAdHocTeam merged commit 173effc into main Feb 18, 2025
10 checks passed
@AdamAdHocTeam AdamAdHocTeam deleted the al-ttahub-3912-cdi-replacement-for-multiple-grants branch February 18, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants