Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2496] cache trivy #2839

Merged
merged 9 commits into from
Nov 13, 2024
Merged

[Issue #2496] cache trivy #2839

merged 9 commits into from
Nov 13, 2024

Conversation

coilysiren
Copy link
Collaborator

@coilysiren coilysiren commented Nov 13, 2024

Summary

Very nearly fixes #2496

Time to review: 1 mins

Context for reviewers

I'm not committing to this 100% solving #2496 because the daily cronjob can fail (on trivy rate limits) which would just mean we are back in the same situation we have always been in. So I want to add retries on this stuff before I can call the issue fully solved.

90% of the meat is this PR is pulled from Trivy's docs, I don't know anything about the oras stuff

@coilysiren coilysiren changed the title cache trivy take 1 cache trivy Nov 13, 2024
@coilysiren coilysiren changed the title cache trivy [Issue #2496] cache trivy Nov 13, 2024
@coilysiren coilysiren marked this pull request as ready for review November 13, 2024 20:44
@coilysiren coilysiren requested a review from acouch as a code owner November 13, 2024 20:44
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please work

@coilysiren coilysiren merged commit 6619408 into main Nov 13, 2024
21 checks passed
@coilysiren coilysiren deleted the kai/cache-trivy branch November 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache trivy
2 participants