72784/edit tram stop on map#1398
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
PasiVuohijoki
force-pushed
the
72784/edit-tram-stop-on-map
branch
3 times, most recently
from
3f34bab to
67d6402
Compare
Huulivoide
approved these changes
Mar 31, 2026
Huulivoide
left a comment
Huulivoide
left a comment
Contributor
There was a problem hiding this comment.
@Huulivoide reviewed 15 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on PasiVuohijoki).
PasiVuohijoki
force-pushed
the
72784/edit-tram-stop-on-map
branch
from
67d6402 to
dce596d
Compare
- Use parseVehicleMode when mapping stop data and filtering by vehicle mode to handle uppercase values (e.g. "TRAM") from the stops database.
When navigating to the map via "show on map" from stop list, stop details or stop area views, the map filters were not adjusted to match the stop's actual vehicle mode or priority.
PasiVuohijoki
force-pushed
the
72784/edit-tram-stop-on-map
branch
from
dce596d to
7478f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of small fixes for how the filters are enabled and stops & stop areas showed when moving into map view from different places.
Added the transportation mode info into edit stop on map dialog.
This change is