fix: utf-8 encodings #205
Merged
fix: utf-8 encodings #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added _strip_quantization_suffix and _build_model_with_size_index to enable accurate aggregation of stats across quantization variants while preserving model size. - Updated IndexedHordeModelStats to build and use these indexes, ensuring that canonical names with org prefixes and quantization variants are correctly matched. - Added tests to verify correct aggregation and breakdown of stats for models with org prefixes and quantization variants. [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci lint: fix
- Added checks to skip legacy database conversion and model reference conversion for categories managed elsewhere (lora, ti). - Updated meta_consts to include these categories and expanded baseline resolution lookup for new image generation baselines.
- Updated all file open operations to explicitly set encoding="utf-8" for reading and writing files across scripts, source, and tests. - This ensures consistent behavior across environments and prevents encoding-related issues when handling non-ASCII data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
open(...)calls did not specify UTF8 encoding, causing problems with emjois/extended characters in certain model references.