[core] Fixed problem with possibly conflicting peer group id#1854
Draft
ethouris wants to merge 2 commits into
Draft
[core] Fixed problem with possibly conflicting peer group id#1854ethouris wants to merge 2 commits into
ethouris wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1838
Problem: Connections with group membership coming from two different applications may occasionally generate the same group ID. This way they are qualified to the same group on the listener side because of having the same peer group ID, although this is unwanted, as they should belong to different groups.
Solution: The peer group should be identified by three factors: Peer address, application ID and the peer group ID. This should fix the problem because:
CONTROVERSY:
There's currently no possible way to extend the Group-type handshake extension. There's a condition that rejects the group extension if it's of size more than 2. This condition must be first removed and only the release in which this is fixed could be in future treated as the oldest backward-compatible version that can work with the release where this PR is merged.