Add NSUserActivityTypeBrowsingWeb handling #3635
Conversation
|
@latenitefilms not sure how to add a a label afterwards, but I guess this is a |
|
I am out of town at the moment, but I will try and carve out some time here in the next couple of days to see about moving some of these forward. |
|
@asmagill any chance of getting this merged? |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Hammerspoon/MJAppDelegate.m
Outdated
| if ([userActivity.activityType isEqualToString:NSUserActivityTypeBrowsingWeb]) { | ||
| [[NSWorkspace sharedWorkspace] openURL:userActivity.webpageURL]; | ||
| } | ||
| return YES; |
There was a problem hiding this comment.
Should this be unconditionally returning YES? The docs suggest that we probably ought to return YES only inside the if statement, and otherwise return NO, right?
|
@mdbraber this is a fantastic update and would solve a major url handling complaint when using hammerspoon as the default browser. Thanks for tackling this! |
|
@mdbraber any updates or thoughts on this? |
|
@megalithic @mdbraber I made the change I think is correct and merged, it would be super helpful if someone could test the Development Build to check this is working. It should be available in an hour or so from: https://github.com/Hammerspoon/hammerspoon/actions/runs/10444554151 |
@cmsj thank you (also to @mdbraber); it works well! was able to handoff an ios brave browser tab to hammerspoon and the URL handlers for hammerspoon took over. 💯 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3635 +/- ##
==========================================
+ Coverage 27.61% 28.12% +0.50%
==========================================
Files 180 191 +11
Lines 36181 43532 +7351
==========================================
+ Hits 9993 12242 +2249
- Misses 26188 31290 +5102 |
|
Great to see this merged while I was away :-) |
To handle Handoff from a native app to a (default) browser
NSUserActivityTypeBrowsingWebneeds to be handled. If a default browser supports this, Handoff links that have awebpageUrlcan be opened by the default browser.More info: https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/Handoff/AdoptingHandoff/AdoptingHandoff.html