Only return YES when we actually handled a user activity #389

Xcode test results

Test Release

Summary

Total	Passed	Failed	Skipped	Expected Failure	⏱️ Time
349	318	31	0	0	5.33s

Test Summary

Hammerspoon Tests

Device: Apple Virtual Machine 1, 14.6.1 (23G93)
SDK: macOS 14.5, 14.5

Test	Total
HSTestCase	2	2	0
HScrash	4	4	0
HSfs	14	13	1
HSaudiodevice	41	34	7
HSrequire_all	3	3	0
HSwebsocket	9	9	0
HSscreen	23	22	1
HSnoises	3	3	0
HStask	10	10	0
HSjsonTests	5	5	0
HSuielementTests	6	3	3
HSbrightness	5	3	2
HSserial	8	4	4
HSapplicationTests	16	12	4
HStimer	22	22	0
HSmouseTests	7	7	0
HSmath	4	4	0
HSimage	3	3	0
HSappfinder	7	7	0
HSbase64	4	4	0
HSdistributednotifications	3	3	0
HSosascript	16	16	0
HSalert	4	4	0
HSinspect	3	3	0
HSwindowTests	19	14	5
HThttp	6	6	0
HShotkey	8	4	4
HScoresetup	16	16	0
HSsocket	42	42	0

LuaSkinTests

Device: Apple Virtual Machine 1, 14.6.1 (23G93)
SDK: macOS 14.5, 14.5

Test	Total
LuaSkinTests	36	36	0	0	0

Failures

Hammerspoon Tests/HSfs/testVolumes

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "testVolumes()".

Hammerspoon Tests/HSaudiodevice/testInputSupportsDataSources

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:193
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testInputSupportsDataSources

Hammerspoon Tests/HSaudiodevice/testDataSourceName

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:236
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testDataSourceName

Hammerspoon Tests/HSaudiodevice/testAllOutputDataSources

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:223
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testAllOutputDataSources

Hammerspoon Tests/HSaudiodevice/testOutputSupportsDataSources

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:199
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testOutputSupportsDataSources

Hammerspoon Tests/HSaudiodevice/testDataSourceSetDefault

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:242
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testDataSourceSetDefault

Hammerspoon Tests/HSaudiodevice/testDataSourceToString

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:230
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testDataSourceToString

Hammerspoon Tests/HSaudiodevice/testCurrentOutputDataSource

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSaudiodevice.m:211
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testCurrentOutputDataSource

Hammerspoon Tests/HSscreen/testRotation

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSscreen.m:101
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testRotation

Hammerspoon Tests/HSuielementTests/testSelectedText

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSuielement.m:53
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testSelectedText

Hammerspoon Tests/HSuielementTests/testApplicationWatcher

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:38
Issue Type	Uncaught Exception
Message	Failed due to unwaited expectation 'testApplicationWatcher()'.

Hammerspoon Tests/HSuielementTests/testWindowWatcher

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:38
Issue Type	Uncaught Exception
Message	Failed due to unwaited expectation 'testWindowWatcher()'.

Hammerspoon Tests/HSbrightness/testGet

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSbrightness.m:30
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testGet

Hammerspoon Tests/HSbrightness/testSet

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSbrightness.m:37
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testSet

Hammerspoon Tests/HSserial/testNewFromPath

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSserial.m:36
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testNewFromPath

Hammerspoon Tests/HSserial/testAttributes

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSserial.m:46
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testAttributes

Hammerspoon Tests/HSserial/testOpenAndClose

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSserial.m:41
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testOpenAndClose

Hammerspoon Tests/HSserial/testNewFromName

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSserial.m:31
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testNewFromName

Hammerspoon Tests/HSapplicationTests/testFrontmostApplication

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSapplication.m:51
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testFrontmostApplication

Hammerspoon Tests/HSapplicationTests/testHiding

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "testHiding()".

Hammerspoon Tests/HSapplicationTests/testAttributesFromBundleID

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSapplication.m:37
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testAttributesFromBundleID

Hammerspoon Tests/HSapplicationTests/testWindows

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "testWindows()".

Hammerspoon Tests/HSwindowTests/testTabs

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSwindow.m:89
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testTabs

Hammerspoon Tests/HSwindowTests/testFullscreenTwo

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "testFullscreenTwoSetup()".

Hammerspoon Tests/HSwindowTests/testOrderedWindows

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSwindow.m:41
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testOrderedWindows

Hammerspoon Tests/HSwindowTests/testMinimize

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSwindow.m:75
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testMinimize

Hammerspoon Tests/HSwindowTests/testDesktop

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSwindow.m:35
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testDesktop

Hammerspoon Tests/HShotkey/testHotkeyStates

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "testHotkeyStates()".

Hammerspoon Tests/HShotkey/testRepeatingHotkey

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "testRepeatingHotkey()".

Hammerspoon Tests/HShotkey/testBasicHotkey

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HSTestCase.m:65
Issue Type	Assertion Failure
Message	Asynchronous wait failed: Exceeded timeout of 2 seconds, with unfulfilled expectations: "testBasicHotkey()".

Hammerspoon Tests/HShotkey/testGetSystemAssigned

File	/Users/runner/work/hammerspoon/hammerspoon/Hammerspoon Tests/HShotkey.m:37
Issue Type	Assertion Failure
Message	(([self luaTestFromSelector:_cmd]) is true) failed - Test failed: testGetSystemAssigned

Code Coverage

		Covered	Executable
CocoaLumberjackPrivacy.bundle	0.00 %	0	0
Hammerspoon.app	51.20 %	1240	2422
MJPreferencesWindowController.m	52.27 %	92	176
HSGrowingTextField.m	37.84 %	14	37
MJAppDelegate.m	20.00 %	56	280
HSExecuteLuaIntentHandler.m	0.00 %	0	30
MJDockIcon.m	85.11 %	40	47
MJLua.m	30.21 %	190	629
MJVersionUtils.m	0.00 %	0	24
HSuicore.m	77.12 %	519	673
MJConsoleWindowController.m	63.06 %	140	222
MJUserNotificationManager.m	48.39 %	15	31
MJFileUtils.m	100.00 %	6	6
HSAppleScript.m	0.00 %	0	62
MJConfigUtils.m	66.67 %	6	9
HSLogger.m	64.06 %	41	64
MJAutoLaunch.m	96.43 %	81	84
MJAccessibilityUtils.m	61.90 %	13	21
MJMenuIcon.m	100.00 %	27	27
LuaSkin.framework	66.07 %	1141	1727
Skin.m	78.09 %	1123	1438
luaskin.m	6.23 %	18	289
Sentry.bundle	0.00 %	0	0
hs	0.00 %	0	319
hs.m	0.00 %	0	319
libASCIImage.a	0.00 %	0	430
PARImage+ASCIIInput.m	0.00 %	0	430
libCocoaAsyncSocket.a	57.12 %	5528	9678
GCDAsyncSocket.m	58.29 %	3248	5572
GCDAsyncUdpSocket.m	55.53 %	2280	4106
libCocoaHTTPServer.a	15.25 %	673	4412
MultipartFormDataParser.m	0.00 %	0	346
DDData.m	39.29 %	44	112
WebSocket.m	51.55 %	233	452
HTTPErrorResponse.m	0.00 %	0	25
DDNumber.m	0.00 %	0	52
DAVConnection.m	0.00 %	0	116
HTTPServer.m	33.02 %	174	527
HTTPConnection.m	12.87 %	173	1344
HTTPAuthenticationRequest.m	0.00 %	0	116
HTTPMessage.m	69.01 %	49	71
HTTPAsyncFileResponse.m	0.00 %	0	281
HTTPDynamicFileResponse.m	0.00 %	0	131
DDRange.h	0.00 %	0	15
HTTPRedirectResponse.m	0.00 %	0	34
HTTPDataResponse.m	0.00 %	0	38
HTTPFileResponse.m	0.00 %	0	132
PUTResponse.m	0.00 %	0	48
MultipartMessageHeaderField.m	0.00 %	0	135
DELETEResponse.m	0.00 %	0	30
DDRange.m	0.00 %	0	64
MultipartMessageHeader.m	0.00 %	0	37
DAVResponse.m	0.00 %	0	306
libCocoaLumberjack.a	7.97 %	326	4088
DDDispatchQueueLogFormatter.m	0.00 %	0	127
DDASLLogger.m	0.00 %	0	59
DDTTYLogger.h	0.00 %	0	1
DDASLLogCapture.m	0.00 %	0	141
CLIColor.m	0.00 %	0	22
DDContextFilterLogFormatter+Deprecated.m	0.00 %	0	24
DDOSLogger.m	71.08 %	59	83
DDTTYLogger.m	0.00 %	0	946
DDFileLogger.m	0.00 %	0	1160
DDAbstractDatabaseLogger.m	0.00 %	0	472
DDMultiFormatter.m	0.00 %	0	79
DDContextFilterLogFormatter.m	0.00 %	0	92
DDFileLogger+Buffering.m	0.00 %	0	139
DDLog.m	35.94 %	267	743
libMIKMIDI.a	1.24 %	97	7839
MIKMIDIUtilities.m	0.00 %	0	162
MIKMIDISystemKeepAliveCommand.m	12.50 %	1	8
MIKMIDICommandThrottler.m	0.00 %	0	22
MIKMIDIMapping.m	0.00 %	0	220
MIKMIDIMetaCuePointEvent.m	33.33 %	2	6
MIKMIDIEventIterator.m	0.00 %	0	88
MIKMIDIMetaTrackSequenceNameEvent.m	16.67 %	2	12
MIKMIDIPolyphonicKeyPressureCommand.m	6.25 %	1	16
MIKMIDIPort.m	0.00 %	0	15
MIKMIDIEntity.m	0.94 %	1	106
MIKMIDIMetaTextEvent.m	7.14 %	2	28
MIKMIDIEndpointSynthesizer.m	0.00 %	0	112
MIKMIDIClientSourceEndpoint.m	0.00 %	0	38
MIKMIDIMetaMarkerTextEvent.m	33.33 %	2	6
MIKMIDITempoEvent.m	7.41 %	2	27
MIKMIDIPitchBendChangeCommand.m	3.57 %	1	28
MIKMIDISequencer.m	0.00 %	0	660
NSUIApplication+MIKMIDI.m	0.00 %	0	120
MIKMIDISourceEndpoint.m	50.00 %	1	2
MIKMIDINoteEvent.m	1.77 %	2	113
MIKMIDIMetronome.m	0.00 %	0	16
MIKMIDITrack.m	0.00 %	0	690
MIKMIDIChannelVoiceCommand.m	2.33 %	1	43
MIKMIDIMetaTimeSignatureEvent.m	2.30 %	2	87
MIKMIDIDestinationEndpoint.m	9.09 %	1	11
MIKMIDINoteOnCommand.m	5.56 %	1	18
MIKMIDIControlChangeEvent.m	5.26 %	2	38
MIKMIDIProgramChangeEvent.m	7.14 %	2	28
MIKMIDISequence.m	0.00 %	0	397
MIKMIDIMetaKeySignatureEvent.m	2.70 %	2	74

Test Details

Hammerspoon Tests

HSTestCase

				⏱️
2 (100%)	0 (0%)	0 (0%)	0 (0%)	0.10s

	`testTestLuaSuccess`
	`testrunLua`

HScrash

				⏱️
4 (100%)	0 (0%)	0 (0%)	0 (0%)	0.10s

	`testResidentSize`
	`testrunLua`
	`testThrowTheWorld`
	`testTestLuaSuccess`

HSfs

				⏱️
13 (93%)	1 (7%)	0 (0%)	0 (0%)	0.12s

	`testLockDir`
	`testChdir`
	`testFileUTI`
	`testDirWalker`
	`testTestLuaSuccess`
	`testTouch`
	`testLock`
	`testAttributes`
	`testVolumes`
	`testTags`
	`testrunLua`
	`testMkdir`
	`testLinks`
	`testRmdir`

HSaudiodevice

				⏱️
34 (83%)	7 (17%)	0 (0%)	0 (0%)	0.10s

	`testFindInputByUID`
	`testGetDefaultEffect`
	`testWatcherCallback`
	`testAllInputDataSources`
	`testOutputVolume`
	`testGetAllInputDevices`
	`testGetDefaultInput`
	`testSetDefaultEffect`
	`testInputSupportsDataSources`
	`testInputVolume`
	`testCurrentInputDataSource`
	`testFindOutputByUID`
	`testTransportType`
	`testGetAllDevices`
	`testIsInputDevice`
	`testToString`
	`testGetCurrentOutput`
	`testDataSourceName`
	`testVolume`
	`testGetCurrentInput`
	`testGetDefaultOutput`
	`testWatcher`
	`testAllOutputDataSources`
	`testTestLuaSuccess`
	`testName`
	`testGetAllOutputDevices`
	`testSetDefaultOutput`
	`testOutputSupportsDataSources`
	`testrunLua`
	`testFindDeviceByName`
	`testDataSourceSetDefault`
	`testSetDefaultInput`
	`testDataSourceToString`
	`testFindOutputByName`
	`testCurrentOutputDataSource`
	`testFindInputByName`
	`testMute`
	`testFindDeviceByUID`
	`testIsOutputDevice`
	`testJackConnected`
	`testUID`

HSrequire_all

				⏱️
3 (100%)	0 (0%)	0 (0%)	0 (0%)	1.42s

	`testTestLuaSuccess`
	`testrunLua`
	`testRequireAll`

HSwebsocket

				⏱️
9 (100%)	0 (0%)	0 (0%)	0 (0%)	0.15s

	`testOpenStatus`
	`testNew`
	`testEchoData`
	`testClosedStatus`
	`testLegacy`
	`testClosingStatus`
	`testEchoText`
	`testrunLua`
	`testTestLuaSuccess`

HSscreen

				⏱️
22 (96%)	1 (4%)	0 (0%)	0 (0%)	0.10s

	`testrunLua`
	`testNextPrevious`
	`testSetPrimary`
	`testFromUnitRect`
	`testName`
	`testMainScreen`
	`testScreenPositions`
	`testSetOrigin`
	`testAllScreens`
	`testAvailableModes`
	`testPosition`
	`testId`
	`testFrames`
	`testScreenshots`
	`testCurrentMode`
	`testFind`
	`testPrimaryScreen`
	`testGamma`
	`testBrightness`
	`testRotation`
	`testToUnitRect`
	`testSetMode`
	`testTestLuaSuccess`

HSnoises

				⏱️
3 (100%)	0 (0%)	0 (0%)	0 (0%)	0.11s

	`testStartStop`
	`testTestLuaSuccess`
	`testrunLua`

HStask

				⏱️
10 (100%)	0 (0%)	0 (0%)	0 (0%)	0.63s

	`testTaskEnvironment`
	`testSimpleTaskFail`
	`testrunLua`
	`testTaskLifecycle`
	`testNewTask`
	`testTaskWorkingDirectory`
	`testTaskBlock`
	`testTestLuaSuccess`
	`testSimpleTask`
	`testStreamingTask`

HSjsonTests

				⏱️
5 (100%)	0 (0%)	0 (0%)	0 (0%)	0.10s

	`testReadWrite`
	`testEncodeDecodeFailures`
	`testTestLuaSuccess`
	`testEncodeDecode`
	`testrunLua`

HSuielementTests

				⏱️
3 (50%)	3 (50%)	0 (0%)	0 (0%)	0.12s

	`testSelectedText`
	`testTestLuaSuccess`
	`testHammerspoonElements`
	`testApplicationWatcher`
	`testWindowWatcher`
	`testrunLua`

HSbrightness

				⏱️
3 (60%)	2 (40%)	0 (0%)	0 (0%)	0.11s

	`testGet`
	`testTestLuaSuccess`
	`testrunLua`
	`testAmbient`
	`testSet`

HSserial

				⏱️
4 (50%)	4 (50%)	0 (0%)	0 (0%)	0.11s

	`testNewFromPath`
	`testTestLuaSuccess`
	`testrunLua`
	`testAttributes`
	`testOpenAndClose`
	`testAvailablePortNames`
	`testNewFromName`
	`testAvailablePortPaths`

HSapplicationTests

				⏱️
12 (75%)	4 (25%)	0 (0%)	0 (0%)	0.25s

	`testrunLua`
	`testForceKilling`

Only return YES when we actually handled a user activity #389

Xcode test results

Xcode test results

Test Release

Summary

Test Summary

Failures

Code Coverage

Details

Test Details

HSTestCase

HScrash

HSfs

HSaudiodevice

HSrequire_all

HSwebsocket

HSscreen

HSnoises

HStask

HSjsonTests

HSuielementTests

HSbrightness

HSserial

HSapplicationTests

Annotations

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

github-actions / Xcode test results

Re-running jobs...