Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor version queries, remove platform download table #1438

Merged
merged 8 commits into from
Feb 8, 2025
Merged

feat: refactor version queries, remove platform download table #1438

merged 8 commits into from
Feb 8, 2025

Conversation

MiniDigger
Copy link
Member

@MiniDigger MiniDigger commented Jan 12, 2025 •
edited
Loading

todo:

  • comment in migration and cleanup
  • actually test migration on a bigger db
  • addDownloadsAndDependencies in VersionDependencyService is ideally completely gone
  • todo check if we can use version compact in more places (where we don't need downloads or deps)
  • getVersions in VersionsApiDAO needs to redo stats stuff, maybe a materialized view?
  • todo check pinned version downloads

@MiniDigger MiniDigger force-pushed the version-db-refactor branch 4 times, most recently from a3b3d6b to 7449487 Compare January 14, 2025 19:07
@MiniDigger MiniDigger marked this pull request as ready for review February 8, 2025 14:21
@MiniDigger MiniDigger merged commit 7b319c0 into staging Feb 8, 2025
1 check passed
@MiniDigger MiniDigger deleted the version-db-refactor branch February 8, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MiniDigger