Possible solution of using DLPack to handle TVM FFI#181
Open
haoran35-jpg wants to merge 3 commits intoHazyResearch:mainfrom
Open
Possible solution of using DLPack to handle TVM FFI#181haoran35-jpg wants to merge 3 commits intoHazyResearch:mainfrom
haoran35-jpg wants to merge 3 commits intoHazyResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two routes are respectively:
tensor.clone() -> TKParallelTensor(tensor, ...)andJAX → __dlpack__() → TKParallelTensor(capsule). The VRAM use is integer because I'm only testing with a single fixed tensor size (50 MB)—i.e. 50×1024×1024/4 float32 elements—so the copy path allocates exactly two buffers (100 MB) and the DLPack path one (50 MB), giving round numbers. Not sure if this is in a good shape of PR? Thank you!