Skip to content

base64 itemstack item#225

Closed
FakEEE14 wants to merge 14 commits intoHelpChat:mainfrom
FakEEE14:main
Closed

base64 itemstack item#225
FakEEE14 wants to merge 14 commits intoHelpChat:mainfrom
FakEEE14:main

Conversation

@FakEEE14
Copy link
Contributor

@FakEEE14 FakEEE14 commented Jul 13, 2025

i made it so you can add "stack-" prefix so you can add any item with placeholder or base64 to make a full item (with displayname, lore, encahntments , ...)

this 'stack-' prefix allows to create an item with nothing set by default, and you can change it if you want

like from this:

  'dailyreward':
    material: bell
    slot: 2
    display_name: '&e&lClick Me'
    lore:
      - '&7'
      - '&7Click to get it'
    item_flags:
      - HIDE_ENCHANTS
    enchantments:
      - DURABILITY;0

to this:

  'dailyreward':
    material: 'stack-base64'
    slot: 2
    item_flags:
      - HIDE_ENCHANTS

or with custom name:

  'dailyreward':
    material: 'stack-base64'
    display_name: '&e&lClick Me'
    slot: 2
    item_flags:
      - HIDE_ENCHANTS

Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have some small issues. The rest looks good. I'm not very sure on the usefulness of the whole idea so I'll let everyone else decide

build.gradle.kts Outdated
compileOnly(libs.itemsadder)
compileOnly(libs.nexo)
compileOnly(libs.oraxen)
compileOnly("io.th0rgal:oraxen:1.190.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the gradle/libs.versions.toml file instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#223 have the same problem, so i solve it for all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but you can change the library in the libs.versions.toml file where it is declared

Copy link
Contributor Author

@FakEEE14 FakEEE14 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i do it in another pull ?
i try to change 1.159.0 to 1.190.0 but idk why refuse to work

FakEEE14 added 4 commits July 14, 2025 23:39
no need to import all
useless space it's spose
wrong comment change
back to where it was
@FakEEE14
Copy link
Contributor Author

FakEEE14 commented Jul 14, 2025

this should be fixed
and the use for it is showing item from different plugins like itemjoin and other custom plugins like oraxen without implementing any apis

no need to import all eather
@FakEEE14
Copy link
Contributor Author

all good ?

@FakEEE14 FakEEE14 requested a review from BlitzOffline July 15, 2025 00:19
BlitzOffline
BlitzOffline previously approved these changes Jul 17, 2025
Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wanted to ask and make sure that you've tested this on at least 2 versions of Minecraft that we support? (1.16.5 since that's the lowest version, and one of the newest versions)?

@FakEEE14
Copy link
Contributor Author

yeah i tested on 1.21.3 and 1.16.5 and both works
if itemstack was bad(even a single word in base64) it's get stoned and put stone by default in the rest of the code

forget this change
@BlitzOffline
Copy link
Member

Feel free to merge main into this so the workflow can run. After that, I'll approve and merge.

@FakEEE14 FakEEE14 deleted the branch HelpChat:main July 17, 2025 17:07
@FakEEE14 FakEEE14 closed this Jul 17, 2025
@FakEEE14 FakEEE14 deleted the main branch July 17, 2025 17:07
@BlitzOffline
Copy link
Member

I'm not sure what you've done but seems the PR got automatically closed. I am unable to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants