base64 itemstack item#225
Conversation
new isItemStackOption
added base64 to item
oraxen 1.159.0 no more
BlitzOffline
left a comment
There was a problem hiding this comment.
I do have some small issues. The rest looks good. I'm not very sure on the usefulness of the whole idea so I'll let everyone else decide
src/main/java/com/extendedclip/deluxemenus/utils/ItemUtils.java
Outdated
Show resolved
Hide resolved
build.gradle.kts
Outdated
| compileOnly(libs.itemsadder) | ||
| compileOnly(libs.nexo) | ||
| compileOnly(libs.oraxen) | ||
| compileOnly("io.th0rgal:oraxen:1.190.0") |
There was a problem hiding this comment.
Please update the gradle/libs.versions.toml file instead.
There was a problem hiding this comment.
#223 have the same problem, so i solve it for all
There was a problem hiding this comment.
Yes but you can change the library in the libs.versions.toml file where it is declared
There was a problem hiding this comment.
should i do it in another pull ?
i try to change 1.159.0 to 1.190.0 but idk why refuse to work
src/main/java/com/extendedclip/deluxemenus/config/DeluxeMenusConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/extendedclip/deluxemenus/utils/ItemUtils.java
Outdated
Show resolved
Hide resolved
no need to import all
useless space it's spose
wrong comment change
back to where it was
|
this should be fixed |
no need to import all eather
|
all good ? |
BlitzOffline
left a comment
There was a problem hiding this comment.
Looks good. Just wanted to ask and make sure that you've tested this on at least 2 versions of Minecraft that we support? (1.16.5 since that's the lowest version, and one of the newest versions)?
|
yeah i tested on 1.21.3 and 1.16.5 and both works |
forget this change
|
Feel free to merge main into this so the workflow can run. After that, I'll approve and merge. |
fix oraxen version missmatch (#226)
|
I'm not sure what you've done but seems the PR got automatically closed. I am unable to reopen it. |
i made it so you can add "stack-" prefix so you can add any item with placeholder or base64 to make a full item (with displayname, lore, encahntments , ...)
this 'stack-' prefix allows to create an item with nothing set by default, and you can change it if you want
like from this:
to this:
or with custom name: