Conversation
BlitzOffline
left a comment
BlitzOffline
left a comment
There was a problem hiding this comment.
Some small changes are needed. Everything else looks fine and once these changes are made, I will approve and merge.
src/main/java/com/extendedclip/deluxemenus/action/ActionType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/extendedclip/deluxemenus/action/ClickActionTask.java
Outdated
Show resolved
Hide resolved
iSnakeBuzz
left a comment
iSnakeBuzz
left a comment
There was a problem hiding this comment.
Improved else-if statements and fix issues related to action names
|
Can this be merged now please? This feature is a need in this plugin. |
|
It seems that there's a conflict remaining. Can you please take a look and ping me? I'll review it as soon as you do that and merge it. Thanks! |
I can't Maybe @iSnakeBuzz ?? |
|
Yeah @VojtechSin they have to do it. Otherwise you have to fork their repository and then make a Pull Request from your forked repository to theirs. |
|
Is there anything else needed here? I don't see any issues or conflicts preventing a merge |
3 participants
Include three new actions in this pull request:
These additions enable the utilization of custom resource-pack sounds, such as those created with ItemsAdder.