Fix SFTP getUrl function for PHP >= 5.6.28 #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 5.6.28 made an (apparently undocumented) change for scanning an SFTP directory. Previously the URL was created by casting the Resource as a string ("Resource Herzult#27"), now it requires it to be cast as an int ("27").
Previously this function returned ssh2.sftp://Resource Herzult#27/my/url, now returns ssh2.sftp://27/my/url.
The "new" method has been tested in 5.6.26 and still works correctly (as well as 5.6.29 and 7.0.14).
|
@Herzult is it going to be merged? It is a required change for the lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.6.28 made an (apparently undocumented) change for scanning an SFTP directory. Previously the URL was created by casting the Resource as a string ("Resource #27"), now it requires it to be cast as an int ("27").
Previously this function returned ssh2.sftp://Resource #27/my/url, now returns ssh2.sftp://27/my/url.
The "new" method has been tested in 5.6.26 and still works correctly (as well as 5.6.29 and 7.0.14).