This repository was archived by the owner on Oct 15, 2020. It is now read-only.
Upgrade/600/ntp #391
Open
Upgrade/600/ntp #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'enhancement/resource_base_class' into Upgrade/600/NTP
Sowmyahsg
requested review from
dileepds,
jyothisgm,
madhav-bharadwaj,
sijeesh and
soodpr
soodpr
reviewed
Aug 24, 2018
| return self.__do_post(uri, {}, timeout, custom_headers) | ||
|
|
||
| def create(self, resource, uri=None, timeout=-1, custom_headers=None, default_values={}): | ||
| def create(self, resource, force=False, uri=None, timeout=-1, custom_headers=None, default_values={}): |
Member
There was a problem hiding this comment.
add force args in the comments section as well
Member
There was a problem hiding this comment.
Also, i would suggest force to be added in the end of args list as it would not break any existing code.
soodpr
reviewed
Aug 24, 2018
| @@ -1,4 +1,4 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # -*- ccding: utf-8 -*- | |||
Member
|
Changelog.md file is missing and also, select what's applicable for your PR in the checklist while raising a PR. |
madhav-bharadwaj
approved these changes
Sep 6, 2018
Member
madhav-bharadwaj
left a comment
madhav-bharadwaj
left a comment
There was a problem hiding this comment.
Looks good to me apart from priyanka's comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ NTP support for API 500 and 600]
Check List
$ tox).