Skip to content

Prevent incorrect move #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent incorrect move #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions SyncPro.Adapters.WindowsFileSystem/WindowsFileSystemAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ public override void UpdateItem(EntryUpdateInfo updateInfo, SyncEntryChangedFlag
else if (updateInfo.Entry.Type == SyncEntryType.Directory)
{
Pre.Assert(!string.IsNullOrEmpty(newFullPath), "newFullPath != null");
Directory.Move(fullPath, newFullPath);
if (fullPath != newFullPath)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better written as string.equals.

Suggested change
if (fullPath != newFullPath)
if (!string.Equals(fullPath, newFullPath))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be better.

Directory.Move(fullPath, newFullPath);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add curly braces here? (common coding style)

}
else
{
Expand Down Expand Up @@ -680,4 +681,4 @@ public void Dispose()
this.fileSystemWatcher?.Dispose();
}
}
}
}