Skip to content

fix: remove accidental 'from json import tool' import; align abstract completion() default #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

fix: remove accidental 'from json import tool' import; align abstract completion() default #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion holmes/core/llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def count_tokens(
def completion(
self,
messages: List[Dict[str, Any]],
tools: Optional[List[Dict[str, Any]]] = [],
tools: Optional[List[Dict[str, Any]]] = None,
tool_choice: Optional[Union[str, dict]] = None,
response_format: Optional[Union[dict, Type[BaseModel]]] = None,
temperature: Optional[float] = None,
Expand Down
1 change: 0 additions & 1 deletion holmes/core/tool_calling_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import concurrent.futures
import json
from json import tool
import logging
import re
import threading
Expand Down