Skip to content
This repository was archived by the owner on Jun 16, 2021. It is now read-only.

Update dependency ws to 7.4.6 [SECURITY]#44

Open
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-ws-vulnerability
Open

Update dependency ws to 7.4.6 [SECURITY]#44
renovate[bot] wants to merge 1 commit intomasterfrom
renovate/npm-ws-vulnerability

Conversation

@renovate
Copy link
Copy Markdown

@renovate renovate bot commented May 31, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.4.3 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] Update dependency ws to 7.4.6 [SECURITY] - autoclosed Jun 1, 2021
@renovate renovate bot closed this Jun 1, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch June 1, 2021 21:27
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] - autoclosed Update dependency ws to 7.4.6 [SECURITY] Jun 5, 2021
@renovate renovate bot reopened this Jun 5, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch June 5, 2021 08:41
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from b4e6bb9 to dc92cbe Compare June 5, 2021 08:42
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] Update dependency ws to 7.4.6 [SECURITY] - autoclosed Jun 15, 2021
@renovate renovate bot closed this Jun 15, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch June 15, 2021 15:15
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] - autoclosed Update dependency ws to 7.4.6 [SECURITY] Jun 15, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch June 15, 2021 16:16
@renovate renovate bot reopened this Jun 15, 2021
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from dc92cbe to 12976dc Compare June 15, 2021 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant