Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/actionlint: various fixes #200

Merged
merged 1 commit into from
Oct 31, 2024
Merged

workflows/actionlint: various fixes #200

merged 1 commit into from
Oct 31, 2024

Conversation

carlocab
Copy link
Member

  • Rename the workflow to Actionlint to match the file name.
  • Persist credentials, but only on private repositories, because
    checking out the repo seems to fail on private repositories without
    doing this.
  • Upload the SARIF file only on public repositories, since this feature
    is not available on private repositories.

- Rename the workflow to `Actionlint` to match the file name.
- Persist credentials, but only on private repositories, because
  checking out the repo seems to fail on private repositories without
  doing this.
- Upload the SARIF file only on public repositories, since this feature
  is not available on private repositories.
@carlocab carlocab merged commit 1e2a29b into master Oct 31, 2024
31 of 32 checks passed
@carlocab carlocab deleted the actionlint-fixes branch October 31, 2024 18:32
@Bo98
Copy link
Member

Bo98 commented Oct 31, 2024

  • Persist credentials, but only on private repositories, because
    checking out the repo seems to fail on private repositories without
    doing this.

You don't need to persist credentials - what you actually need is the contents: read permission which is missing here.

@carlocab
Copy link
Member Author

Gotcha, thanks for the tip. #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants