set max-width of post images to 100% #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @koddsson! |
MikeMcQuaid
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just checking out the new blog post on my phone and it looked a bit off. Turns out that the images have a set width that exceeds the viewport on smaller devices, not quite sure why but maybe this was a good "magic variable" at some point which worked well on larger viewports?
I changed the
widthproperty to100%to make sure that the image doesn't overflow it's container and then will never overflow beyond the text in the wrapped container.(Screenshots on emulated iPhone 14 Pro Max in the Chrome DevTools)