Add pretty permalink to alt lang index files #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing alternative language files currently use an
`/index_{langcode}.html` path. While this is perfectly functional,
it's not as pretty as it could be. It's not uncommon for websites to
use a language path for alternative languages (e.g., `/fr/`) when
they use one domain for all languages.
This commit adds a `permalink` value to the front matter of all the
alternative language index files, so they will use cleaner URLs. This
also updates the URLs used in the `link` tags and the JavaScript for
the language `select` element accordingly.
SMillerDev
approved these changes
Sep 7, 2023
|
Seems fine, thanks @samford. Would be good to get some linting here at some point; you've been adding more and more required attributes for translations and it's unclear what the failure states are if/when any of them are omitted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing alternative language files currently use an
/index_{langcode}.htmlpath. While this is perfectly functional, it's not as pretty as it could be. It's not uncommon for websites to use a language path for alternative languages (e.g.,/fr/) when they use one domain for all languages.This commit adds a
permalinkvalue to the front matter of all the alternative language index files, so they will use cleaner URLs. This also updates the URLs used in thelinktags and the JavaScript for the languageselectelement accordingly.