Avoid render-blocking with Algolia CSS #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Algolia CSS only applies to the search box (which renders dynamically), so we can safely defer it. This resolves the "Eliminate render-blocking resources" item in PageSpeed Insights and Lighthouse.
SMillerDev
approved these changes
Sep 9, 2023
|
Can we make those checks part of CI? |
I believe it's technically possible (e.g., https://github.com/GoogleChrome/lighthouse-ci) but may require quite a bit of work. I'm primarily focused on resolving our current issues at the moment and was planning to look into adding some additional validation/linting/etc. to CI sometime after. |
I appreciate the intent here but: without adding CI as we go along they are likely to regress. |
|
Thanks @samford! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Algolia CSS only applies to the search box (which renders dynamically), so we can safely defer it. This resolves the "Eliminate render-blocking resources" item in PageSpeed Insights and Lighthouse.