livecheck: finish expanding typed: strict

I previously expanded use of `typed: strict` in livecheck files but the exception was `livecheck/strategy.rb`. This addresses the `@strategies` type errors in that file and upgrades it to `typed: strict`. Co-authored-by: apainintheneck <[email protected]>
Homebrew · Jul 8, 2024 · 17d1561 · 17d1561
1 parent 2e2dc59
commit 17d1561
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/Library/Homebrew/livecheck/strategy.rb b/Library/Homebrew/livecheck/strategy.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module Homebrew
@@ -97,17 +97,13 @@ module Strategy
       # @return [Hash]
       sig { returns(T::Hash[Symbol, T.untyped]) }
       def strategies
-        return @strategies if defined? @strategies
-
-        @strategies = {}
-        Strategy.constants.sort.each do |const_symbol|
+        @strategies ||= T.let(Strategy.constants.sort.each_with_object({}) do |const_symbol, hash|
           constant = Strategy.const_get(const_symbol)
           next unless constant.is_a?(Class)
 
           key = Utils.underscore(const_symbol).to_sym
-          @strategies[key] = constant
-        end
-        @strategies
+          hash[key] = constant
+        end, T.nilable(T::Hash[Symbol, T.untyped]))
       end
       private_class_method :strategies