Skip to content

Commit

Permalink
formula: fix alias/generic/prepend std_cmake_args issue.
Browse files Browse the repository at this point in the history
Seen in:
Homebrew/homebrew-core#191090 (comment)

There's a missing signature issue here due to the `generic_*` aliasing
we're doing. With prepend, though: this is no longer needed and we can
use `super` instead which is more idiomatic and nicer overall.

This pattern should probably be applied in other places but: let's try
this targetting fix for here first.
  • Loading branch information
MikeMcQuaid committed Sep 20, 2024
1 parent d8fd19d commit eab3229
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion Library/Homebrew/extend/os/mac/formula.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def valid_platform?
).returns(T::Array[String])
}
def std_cmake_args(install_prefix: prefix, install_libdir: "lib", find_framework: "LAST")
args = generic_std_cmake_args(install_prefix:, install_libdir:, find_framework:)
args = super

Check warning on line 24 in Library/Homebrew/extend/os/mac/formula.rb

View check run for this annotation

Codecov / codecov/patch

Library/Homebrew/extend/os/mac/formula.rb#L24

Added line #L24 was not covered by tests

# Avoid false positives for clock_gettime support on 10.11.
# CMake cache entries for other weak symbols may be added here as needed.
Expand Down
1 change: 0 additions & 1 deletion Library/Homebrew/formula.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1822,7 +1822,6 @@ def std_cmake_args(install_prefix: prefix, install_libdir: "lib", find_framework
-DBUILD_TESTING=OFF
]
end
alias generic_std_cmake_args std_cmake_args

# Standard parameters for configure builds.
sig {
Expand Down

0 comments on commit eab3229

Please sign in to comment.