rubocop: Use Sorbet/StrictSigil
as it's better than comments
#18023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: strict
in all (non-package) files in Homebrew organisation #17297.undef
that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary.# typed: strict
in new code #18018 (comment).rubocop:disable
for the files that can't betyped: strict
(use of undef, required before everything else, etc) andrubocop:todo
for everything else that should be tried to make strictly typed. There's no functional difference between the two asrubocop:todo
isrubocop:disable
with a different name.typed: strict
isn't going to gain us anything for some Markdown linting config files.