Bump more files to Sorbet typed: strict
#18354
Open
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Sep 19, 2024
| @@ -38,7 +39,9 @@ def migrate(dry_run: false) | |||
| old_caskroom_path = old_cask.caskroom_path | |||
| new_caskroom_path = new_cask.caskroom_path | |||
|
|
|||
| old_installed_caskfile = old_cask.installed_caskfile.relative_path_from(old_caskroom_path) | |||
| return if (old_caskfile = old_cask.installed_caskfile).nil? | |||
There was a problem hiding this comment.
Suggested change
| return if (old_caskfile = old_cask.installed_caskfile).nil? | |
| old_caskfile = old_cask.installed_caskfile | |
| return if old_caskfile.nil? |
Don't feel strongly but this format makes more sense to me when the variable's reused below so the definition is not "hidden".
| cmd: T.nilable(String), | ||
| empty_argv: T::Boolean, | ||
| usage_error: T.nilable(String), | ||
| remaining_args: T.nilable(T::Array[String]) |
There was a problem hiding this comment.
Suggested change
| remaining_args: T.nilable(T::Array[String]) | |
| remaining_args: T::Array[String]) |
feels nicer if possible given the default parameter is []
| params( | ||
| cmd: String, | ||
| path: Pathname, | ||
| remaining_args: T.nilable(T::Array[String]), |
There was a problem hiding this comment.
Suggested change
| remaining_args: T.nilable(T::Array[String]), | |
| remaining_args: T::Array[String], |
feels nicer if possible given there's no default parameter
| sig { | ||
| params( | ||
| path: Pathname, | ||
| remaining_args: T.nilable(T::Array[String]) |
There was a problem hiding this comment.
Suggested change
| remaining_args: T.nilable(T::Array[String]) | |
| remaining_args: T::Array[String] |
|
|
||
| # Try parsing arguments here in order to show formula options in help output. | ||
| cmd_parser.parse(remaining_args, ignore_invalid_options: true) | ||
| cmd_parser.generate_help_text | ||
| end | ||
| private_class_method :parser_help | ||
|
|
||
| sig { params(path: Pathname).returns(T::Array[T.nilable(String)]) } |
There was a problem hiding this comment.
Suggested change
| sig { params(path: Pathname).returns(T::Array[T.nilable(String)]) } | |
| sig { params(path: Pathname).returns(T::Array[String]) } |
| def self.command_help_lines(path) | ||
| path.read | ||
| .lines | ||
| .grep(/^#:/) | ||
| .map { |line| line.slice(2..-1).delete_prefix(" ") } | ||
| .map { |line| line.slice(2..-1)&.delete_prefix(" ") } |
There was a problem hiding this comment.
Suggested change
| .map { |line| line.slice(2..-1)&.delete_prefix(" ") } | |
| .filter_map { |line| line.slice(2..-1)&.delete_prefix(" ") } |
means it'll be T::Array[String]
carlocab
approved these changes
Sep 19, 2024
Comment on lines
+447
to
448
| sig { params(file: T.any(Pathname, String), objdump: String).returns(T::Boolean) } | ||
| def cpuid_instruction?(file, objdump = "objdump") |
There was a problem hiding this comment.
Suggested change
| sig { params(file: T.any(Pathname, String), objdump: String).returns(T::Boolean) } | |
| def cpuid_instruction?(file, objdump = "objdump") | |
| sig { params(file: T.any(Pathname, String), objdump: Pathname).returns(T::Boolean) } | |
| def cpuid_instruction?(file, objdump) |
There was a problem hiding this comment.
The Pathname part is actually necessary since callers above pass objdump as a Pathname.
| def cpuid_instruction?(file, objdump = "objdump") | ||
| @instruction_column_index ||= {} | ||
| @instruction_column_index ||= T.let({}, T.nilable(T::Hash[String, T.untyped])) |
There was a problem hiding this comment.
Suggested change
| @instruction_column_index ||= T.let({}, T.nilable(T::Hash[String, T.untyped])) | |
| @instruction_column_index ||= T.let({}, T.nilable(T::Hash[String, Integer])) |
I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?typed: strictin all (non-package) files in Homebrew organisation #17297.