cmd/upgrade: require named args when upgrading from source #18572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --build-from-source flag can currently be used without specifying a formula by name but it doesn't behave the way you'd expect it to. It will upgrade everything using bottles if they are available and skip building things from source. This is intentional because we want to discourage non-developers from building packages from source since the result is less predictable. The change here is to error out in that case. It might be smarter to go through the entire deprecation cycle here just in case someone is using this in scripts.
apainintheneck
changed the title
MikeMcQuaid
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
This makes sense! I don't think we need a deprecation cycle here. Thanks again @apainintheneck!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Resolves #18226
The
--build-from-sourceflag can currently be used without specifying a formula by name but it doesn't behave the way you'd expect it to.It will upgrade everything using bottles if they are available and skip building things from source. This is intentional because we want to discourage non-developers from building packages from source since the result is less predictable.
The change here is to error out in that case. It might be smarter to go through the entire deprecation cycle here just in case someone is using this in scripts.