Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --caskroom flag. #2672

Merged
merged 2 commits into from
May 24, 2017
Merged

Deprecate --caskroom flag. #2672

merged 2 commits into from
May 24, 2017

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

cc @adidalal, @claui, @fanquake, @miccal, @victorpopkov

Closes Homebrew/homebrew-cask#21858.

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label May 23, 2017
vitorgalvao
vitorgalvao reviewed May 23, 2017
View reviewed changes
Library/Homebrew/manpages/brew-cask.1.md Outdated
@@ -255,7 +252,7 @@ Environment variables specific to Homebrew-Cask:
the command-line. This is particularly useful to make options persistent.
For example, you might add to your .bash_profile or .zshenv something like:

export HOMEBREW_CASK_OPTS='--appdir=/Applications --caskroom=/etc/Caskroom'
export HOMEBREW_CASK_OPTS='--appdir=/Applications --fontdir=/Library/Fonts'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of --appdir=/Applications, it should be --appdir=~/Applications, since /Applications is now the default, you wouldn’t set a flag for it.

@reitermarkus reitermarkus force-pushed the deprecate-caskroom-flag branch 6 times, most recently from a7c0edb to 4a4820e Compare May 24, 2017 00:46
@reitermarkus reitermarkus merged commit e931fee into Homebrew:master May 24, 2017
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label May 24, 2017
@reitermarkus reitermarkus deleted the deprecate-caskroom-flag branch May 24, 2017 22:45
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miccal miccal miccal approved these changes

@vitorgalvao vitorgalvao vitorgalvao approved these changes

@jawshooah jawshooah Awaiting requested review from jawshooah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reitermarkus @vitorgalvao @miccal @BrewTestBot