Skip to content

Commit

Permalink
add appcast stanza for findings.rb
Browse files Browse the repository at this point in the history
  • Loading branch information
@rolandwalker
rolandwalker committed Jun 3, 2014
1 parent cb00381 commit 0cad9f7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Casks/findings.rb
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
class Findings < Cask
url 'http://downloads.findingsapp.com/Findings_2133_1.0.zip'
appcast 'http://downloads.findingsapp.com/appcast.xml'
homepage 'http://findingsapp.com'
version '1.0'
sha256 'f46d73e1f384d08136ef95c0d2881c422122d677c2bf78fe524e8c47aad98259'
Expand Down

3 comments on commit 0cad9f7

@cparnot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the url should be 'http://downloads.findingsapp.com/findings'

@rolandwalker
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Cool app!

It's possible to use that unversioned download URL in our DSL by setting version to
'latest' and unsetting the sha256 to turn off validity check on the downloaded file.

But I'm actually trying to move in the other direction, to always use explicit versioning
(and checksumming) in the DSL so that our software can learn to manage upgrades,
per many user requests (#309). Roadmap at #4678.

Currently, we are very good at installing, inconsistent at uninstalling, and pretty much
incapable of upgrading. Adding the appcast stanza is part of that same effort:
we should first be able to use it to detect when a Cask needs to be revised, and
later give users an option to find and install the most recent version per the appcast.

There's also a comment about this point at #1021 (comment) .

@cparnot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed and fast answer! That setup makes sense, given your goals and the roadmap. I'll try to remember to add a pull request for major updates to the app. All the best on your project!

Please sign in to comment.