Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmg-canvas: use versioned url #174658

Merged
merged 1 commit into from
May 23, 2024
Merged

dmg-canvas: use versioned url #174658

merged 1 commit into from
May 23, 2024

Conversation

samford
Copy link
Member

@samford samford commented May 23, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

In reviewing dmg-canvas recently, I noticed that versions can be found on an upstream page listing previous versions, which includes the current one. Assuming this is updated in a timely fashion (i.e., when a new release is made), we can use the versioned zip files and check the aforementioned page for version information instead of having to use ExtractPlist.

Related to #171006.

@samford samford added the livecheck Issues or PRs related to livecheck label May 23, 2024
@krehel krehel enabled auto-merge May 23, 2024 13:21
@krehel krehel merged commit 6a27241 into master May 23, 2024
9 checks passed
@krehel krehel deleted the dmg-canvas-versioned-url branch May 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants