Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boom-3d: update livecheck #185788

Merged
merged 1 commit into from
Sep 18, 2024
Merged

boom-3d: update livecheck #185788

merged 1 commit into from
Sep 18, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Sep 18, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to #171006.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Sep 18, 2024
@bevanjkay
Copy link
Member

Looks like there is a versioned url available, but I can't capture one of the parts in the url without sending a POST request.

https://d3jbf8nvvpx3fh.cloudfront.net/Boom3D/Update/v2.2/54/Boom_3D_Update.dmg

@bevanjkay
Copy link
Member

bevanjkay commented Sep 18, 2024

Actually the first release is available - https://d3jbf8nvvpx3fh.cloudfront.net/Boom3D/Update/v2.2/Boom_3D_Update.dmg (https://d3jbf8nvvpx3fh.cloudfront.net/Boom3D/Update/v#{version}/Boom_3D_Update.dmg)

But looks like 2.2 was updated to a new build without a full version bump, so it returns a different version to the latest url.

@chenrui333 chenrui333 merged commit 8a21ee2 into master Sep 18, 2024
8 checks passed
@chenrui333 chenrui333 deleted the update-boom-3d branch September 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants