Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbotax 2024.r15.016 (new cask) #200014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickthegroot
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@p-linnane
Copy link
Member

I'm wondering if we should handle this like the German tax software we also distribute (e.g. https://github.com/Homebrew/homebrew-cask/blob/master/Casks/w/wiso-steuer-2025.rb). Thoughts @Homebrew/cask?

@nickthegroot
Copy link
Author

I'm wondering if we should handle this like the German tax software we also distribute (e.g. https://github.com/Homebrew/homebrew-cask/blob/master/Casks/w/wiso-steuer-2025.rb). Thoughts @Homebrew/cask?

I saw the discussion that happened on that PR and implemented it that way first, but decided to play it by the books for my first contribution. I prefer turbotax-24 or turbotax-2024 - happy to switch if others agree!

@bevanjkay
Copy link
Member

turbotax-2024 aligns the token with the app name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants