Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freelens 0.1.3 (new cask) #200076

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dex4er
Copy link

@dex4er dex4er commented Jan 30, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Casks/f/freelens.rb Outdated Show resolved Hide resolved
Casks/f/freelens.rb Outdated Show resolved Hide resolved
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @dex4er! 🎉

Comment on lines +14 to +17
livecheck do
url :url
strategy :github_latest
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github_latest livecheck strategy is only required when the upstream repository uses GitHub prereleases or has tags without a corresponding release. It looks like the default (and preferred) git strategy will suffice here. If this is the case the livecheck block can be removed, as the git strategy will be inferred automatically from the url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants