Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leader-key 1.6.0 (new cask) #200099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Jan 30, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@@ -0,0 +1,21 @@
cask "leader-key" do
version "1.6.0"
sha256 :no_check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 :no_check
sha256 "79aae74c790166dd806cac27f94fd6aacdbee889622084e13f326f65ea19035f"

@@ -0,0 +1,21 @@
cask "leader-key" do
version "1.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version "1.6.0"
version "1.6.0,57"

version "1.6.0"
sha256 :no_check

url "https://leader-key-updates.s3.amazonaws.com/Leader%20Key-latest.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://leader-key-updates.s3.amazonaws.com/Leader%20Key-latest.zip",
url "https://leader-key-updates.s3.amazonaws.com/Leader%20Key.b#{version.csv.second}.zip",


livecheck do
url "https://leader-key-updates.s3.amazonaws.com/appcast.xml"
strategy :sparkle, &:short_version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strategy :sparkle, &:short_version
regex(%r{/Leader%20Key[._-]b(\d+(?:\.\d+)*)\.zip}i)
strategy :sparkle do |item, regex|
match = item.url.match(regex)
next if match.blank?
"#{item.short_version},#{match[1]}"
end

strategy :sparkle, &:short_version
end

depends_on macos: ">= :ventura"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on macos: ">= :ventura"
auto_updates true
depends_on macos: ">= :ventura"

url "https://leader-key-updates.s3.amazonaws.com/Leader%20Key-latest.zip",
verified: "leader-key-updates.s3.amazonaws.com/"
name "Leader Key"
desc "*faster than your launcher* launcher"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc "*faster than your launcher* launcher"
desc "Application launcher"

@khipp khipp changed the title Leader Key 1.6.0 (new cask) leader-key 1.6.0 (new cask) Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants