Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update airmail.rb #5260

Closed
wants to merge 2 commits into from
Closed

Update airmail.rb #5260

wants to merge 2 commits into from

Conversation

lufeihaidao
Copy link

No description provided.

@nanoxd
Copy link
Contributor

nanoxd commented Jul 9, 2014

@lufeihaidao Currently version :latest is a better approach than versioning it until #4678 is implemented. Is there any reason why this cask warrants moving formats?

@nanoxd nanoxd added the cask label Jul 9, 2014
@lufeihaidao
Copy link
Author

Hi I've fixed that. Sorry for the first commit to cask

@vitorgalvao
Copy link
Member

@lufeihaidao You’re still changing the url to a versioned one that points to the exact same download, so including this would be a regression, as @nanoxd pointed out. Thank you for the contribution, but this one shouldn’t be included.

@lufeihaidao
Copy link
Author

OK, it means airmail now is better to be latest, right?

@vitorgalvao
Copy link
Member

Yes, that is correct.

@vitorgalvao vitorgalvao mentioned this pull request Aug 5, 2014
Closed
@miccal miccal removed the cask label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lufeihaidao @nanoxd @vitorgalvao @miccal