Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use app instead of suite in sketchup #7402

Closed
wants to merge 1 commit into from
Closed

use app instead of suite in sketchup #7402

wants to merge 1 commit into from

Conversation

vitorgalvao
Copy link
Member

Only three apps and nothing else in the directory. No reason why suite should be used.

@tapeinosyne
Copy link
Contributor

An argument for suite is that these three applications are meant to be complementary, and their origin would be unclear were they linked as standalone.

Generally, I would argue that software suites should be linked as suite, regardless of the number of actual “launchables”.

@ydesgagn
Copy link
Contributor

Personally I think using suite is better than app in that case to keep them grouped together. But the suite link doesn't create anything for me. See #7382. Does all suite links have problems in Yosemite or this is only sketchup?

@vitorgalvao
Copy link
Member Author

@ndr-qef Although I don’t disagree with the sentiment, I don’t really buy the reasoning.

Take yacreader. Those apps are complimentary as well, why are they not a suite (they’re not inside a directory)? Or lyrics-master, that contains only one executable, a readme, and a directory of iTunes scripts. Another example is chemdoodle, which has only the executable and a bunch of resources, but is linked as a suite, while noiz2sa does exactly the same but is linked as an app.

I found (only did a superficial search, admittedly) no discussion on this, regarding this particular cask. It seems it’s only suite on account of all the apps being inside a directory on the dmg; nothing more.

their origin would be unclear were they linked as standalone.

This in particular, I don’t buy. You presumably already know the apps sketchup consists of (and even if you don’t, it tells you when linking via homebrew-cask) because we’re not a discoverability service. Their icons are also very similar and clearly follow a pattern. Lastly, I’ve yet to see (or don’t remember) confusion stemming from something like this1. If you say grouping them together offers some mental consistency, or is logical giving how they work together (I wouldn’t know, as I haven’t used them), that I can get behind. Their origin being unclear is something I really don’t see.

Having said that, I don’t feel it’s such that big of a deal in this case, so we should keep it as is (as I said, I can see the sentiment of what you mean). We should fix those other cases, though, to have some consistency.


1 I’m only recalling Adobe apps as a suite, as an example. Their apps aren’t all under a single Adobe directory, and no one has ever been confused by that. They do mostly (not all, if I recall correctly) start with “Adobe” in the name, so it’s not a good example.

@vitorgalvao vitorgalvao deleted the sketchup branch November 17, 2014 17:37
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants