Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toontown launcher.app #8037

Merged
merged 1 commit into from
Dec 14, 2014
Merged

add toontown launcher.app #8037

merged 1 commit into from
Dec 14, 2014

Conversation

vitorgalvao
Copy link
Member

Closes #8035.

@tapeinosyne
Copy link
Contributor

Is there value in duplicating the token as a name stanza when the branding clearly uses a different proper name? With regard to toontown-launcher, there seems to be clear indication that the software's name (as understood by vendor and users) is ”Toontown Rewritten”, while “Toontown Launcher” is an incidentality of the app bundle.

@DarthMDev
Copy link
Contributor

Yep thats why i used toontown-rewritten

@vitorgalvao
Copy link
Member Author

@mgracer48 As linked in my comment, the name you gave didn’t conform to the token reference, as that must follow the app bundle’s name. name also wasn’t freeform, but a direct copy of the token.

@ndr-qef Duplicating the token as name is as a preparation to when name becomes mandatory. As to the app’s branding, it isn’t as clear as it seems at first (far from it, the more I look into it). “Toontown Rewritten” is used on the website and on the app bundle’s name when viewed in the Finder, while “Toontown Launcher” is used on the mounted dmg, the app’s name in the Terminal, and when opening the app itself.


The discrepancy between the name in the Finder and in a shell, which I only noticed when writing this reply, will also need to be fixed like devonthink-pro-office.

@DarthMDev
Copy link
Contributor

I see, I get it now.

@rolandwalker
Copy link
Contributor

@ndr-qef it's a good point that name is repetitive, but when implementing I didn't see a way around that compromise, because there isn't an algorithm to go from token -> name in all cases.

A notation meaning "this name could be generated by capitalization of the token" would take up as many lines as just writing out the name, and would make Casks non-uniform.

vitorgalvao added a commit that referenced this pull request Dec 14, 2014
@vitorgalvao vitorgalvao merged commit ca03dba into Homebrew:master Dec 14, 2014
@vitorgalvao vitorgalvao deleted the fix-8035 branch December 14, 2014 17:35
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants