Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TuneUp to use app installer #9781

Merged
merged 1 commit into from
Feb 26, 2015
Merged

Fix TuneUp to use app installer #9781

merged 1 commit into from
Feb 26, 2015

Conversation

saulshanabrook
Copy link
Contributor

No description provided.

fanquake added a commit that referenced this pull request Feb 26, 2015
@fanquake
Merge pull request #9781 from saulshanabrook/patch-3
84f694b 
Fix TuneUp to use app installer
@fanquake fanquake merged commit 84f694b into Homebrew:master Feb 26, 2015
@rolandwalker
Copy link
Contributor

Thanks for the fix!

For the record, installer :manual should also have a matching uninstall stanza, or we won't know how to uninstall the Cask. I added a comment line to this Cask, and listed it on the todo at #6872 (you can see there are a number of unfixed problems there.)

@saulshanabrook saulshanabrook deleted the patch-3 branch February 26, 2015 16:04
@saulshanabrook
Copy link
Contributor Author

@rolandwalker Thanks for catching that. I will look into the uninstall procedure to see if I can figure out how to add one.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saulshanabrook @rolandwalker @fanquake