-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghostscript 10.03.0 #165394
Merged
Merged
ghostscript 10.03.0 #165394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Rui Chen <[email protected]> ghostscript: update patch comment Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
ghostscript-10.03.0
branch
from
March 7, 2024 17:07
7a016b5
to
0170016
Compare
fxcoudert
approved these changes
Mar 7, 2024
chenrui333
added
the
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
label
Mar 7, 2024
|
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
Mar 8, 2024
carlocab
reviewed
Sep 19, 2024
Comment on lines
-143
to
-163
diff --git a/configure b/configure | ||
index bfa0985..8de469c 100755 | ||
--- a/configure | ||
+++ b/configure | ||
@@ -12805,11 +12805,11 @@ case $host in | ||
;; | ||
*-darwin*) | ||
DYNAMIC_CFLAGS="-fPIC $DYNAMIC_CFLAGS" | ||
- GS_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(GS_SONAME_MAJOR_MINOR)" | ||
- PCL_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(PCL_SONAME_MAJOR_MINOR)" | ||
- XPS_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(XPS_SONAME_MAJOR_MINOR)" | ||
- PDL_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(GPDL_SONAME_MAJOR_MINOR)" | ||
- PDF_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(PDF_SONAME_MAJOR_MINOR)" | ||
+ GS_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(GS_SONAME_MAJOR)" | ||
+ PCL_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(PCL_SONAME_MAJOR)" | ||
+ XPS_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(XPS_SONAME_MAJOR)" | ||
+ PDL_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(GPDL_SONAME_MAJOR)" | ||
+ PDF_DYNAMIC_LDFLAGS="-dynamiclib -install_name $DARWIN_LDFLAGS_SO_PREFIX\$(PDF_SONAME_MAJOR)" | ||
DYNAMIC_LIBS="" | ||
SO_LIB_EXT=".dylib" | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this patch shouldn't have been removed. The removal is now causing problems at #191187. Please be more careful about this in the future. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
outdated
PR was locked due to age
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?relates to: